Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files paragraph #405

Merged
merged 4 commits into from
May 13, 2024
Merged

Files paragraph #405

merged 4 commits into from
May 13, 2024

Conversation

yepzdk
Copy link
Contributor

@yepzdk yepzdk commented May 8, 2024

@yepzdk yepzdk marked this pull request as ready for review May 8, 2024 13:10
@yepzdk yepzdk changed the title Feature/1289 files paragraph Files paragraph May 8, 2024
@rimi-itk rimi-itk self-requested a review May 8, 2024 14:03
Copy link
Contributor

@rimi-itk rimi-itk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems very similar to the field_media_document field on the hearing content type where a list of documents can be added to a hearing. Do we really need a paragraph type for this?

Does having a paragraph make it easier for us to control the design, say, or are there other benefits in using a paragraph?
Using a paragraph will make it possible to order the list of files, but I don't know if that outweighs the potential overhead in using (and maintaining) a paragraph.

@yepzdk
Copy link
Contributor Author

yepzdk commented May 13, 2024

Thank you for your insights @rimi-itk
True, this is very similar to the files on a hearing. But unlike on hearing we do not have a dedicated order for the fields on Project and Project page. These pages need more freedom to control the design/order and add files in different places of the content order.

Just curious - Why do you think there is a potential overhead in maintaining a paragraph?

@yepzdk yepzdk requested a review from rimi-itk May 13, 2024 08:11
@yepzdk yepzdk merged commit eed18ed into develop May 13, 2024
12 checks passed
@yepzdk yepzdk deleted the feature/1289-files-paragraph branch May 13, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants