KUNST-72: The big upgrade #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimi-itk
force-pushed
the
feature/KUNST-72-update
branch
from
b60b50b
to
26306f2
Compare
rimi-itk
force-pushed
the
feature/KUNST-72-update
branch
from
26306f2
to
1664486
Compare
rimi-itk
force-pushed
the
feature/KUNST-72-update
branch
from
ddc488e
to
e18c3d6
Compare
rimi-itk
force-pushed
the
feature/KUNST-72-update
branch
from
e18c3d6
to
bec2f4c
Compare
tuj
requested changes
Aug 2, 2023
.env
Outdated
| DATABASE_URL=mysql://db:db@mariadb:3306/db | ||
| # Override to use mariadb as backend | ||
| DATABASE_SERVER_VERSION='mariadb-10.3.13' | ||
| ###< doctrine/doctrine-bundle ### | ||
|
|
||
| APP_SECRET=NotSoSecretReplace |
There was a problem hiding this comment.
APP_SECRET defined two times in the file
|
|
||
| # Build assets using our development setup | ||
| docker compose run --rm node yarn install | ||
| docker compose run --rm node yarn build |
There was a problem hiding this comment.
and remove the node_modules folder
| public function up(Schema $schema): void | ||
| { | ||
| // The migration_versions table exists only if upgrading, i.e. not making a fresh install. | ||
| $this->addSql('DROP TABLE IF EXISTS migration_versions'); |
There was a problem hiding this comment.
I've updated the comment above the line with more details and a reference to https://github.com/doctrine/DoctrineMigrationsBundle/blob/3.2.x/UPGRADE.md#from-2x-to-300 (cf. 5a80bb3).
How de we usually handle this situation? Do we add configuration to keep the migration_versions table name?
There was a problem hiding this comment.
"and existing database" => "an existing database"
tuj
approved these changes
Aug 4, 2023
rimi-itk
force-pushed
the
feature/KUNST-72-update
branch
from
5a80bb3
to
b2d17ca
Compare
feature/KUNST 72 update assets
rimi-itk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.itkdev.dk/browse/KUNST-72
Upgrades to
Assets, i.e. Webpack and the like, are not yet upgraded.
The commit history is a mess and we should rebase into a single commit if this is ever approved (or squash when merging).