Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TVIST1-786: Bumped subject max length #317

Merged
merged 1 commit into from
Feb 15, 2023
Merged

TVIST1-786: Bumped subject max length #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ about writing changes to this log.

## [Unreleased]

- Bumped digital post max subject length to 50 characters

## [1.1.0] 2023-02-15

- Added check for updated changelog.
Expand Down
10 changes: 6 additions & 4 deletions src/Service/DigitalPostHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,13 @@ class DigitalPostHelper extends DigitalPost
/**
* Maximum length of digital post subject.
*
* It's not obvious, i.e. clearly documented, what the maximum length actually
* is, but XSDs embedded in the documentation on
* https://digitaliseringskataloget.dk/integration/sf1600 suggest that it's 34.
* https://docs.kombit.dk/integration/sf1600/2.5/pakke > "SF1600 - Print på
* Serviceplatformen v.2.5.pdf" > Page 76:
*
* > Titel på dokumentet. Ved forsendelser til eBoks, må der maksimalt
* > angives 50 tegn.
*/
public const SUBJECT_MAX_LENGTH = 34;
public const SUBJECT_MAX_LENGTH = 50;

private array $serviceOptions;

Expand Down