Rector code cleanup #321
Rector code cleanup #321
Conversation
rimi-itk
force-pushed
the
feature/rector
branch
from
70534ff
to
4664981
Compare
| #[ORM\ManyToOne(targetEntity: 'CaseEntity', inversedBy: 'caseDocumentRelation')] | ||
| #[ORM\JoinColumn(nullable: false)] | ||
| private ?\App\Entity\CaseEntity $case = null; |
There was a problem hiding this comment.
I know all the changes is done by rector, but should we consider removing the ? and = null when the properties are not nullable?
| { | ||
| return $this->caseNumber; | ||
| return (string) $this->caseNumber; |
There was a problem hiding this comment.
I dont think this type-casting is necessary, but i see why rector has done it. caseNumber is not nullable, but when we use make:entity it still creates the getCaseNumber method with return value ?string. However, it does no harm so lets just keep it.
| @@ -44,9 +35,9 @@ public function setType(?string $type): self | |||
| return $this; | |||
| } | |||
|
|
|||
| public function getIdentifier(): ?string | |||
| public function getIdentifier(): string | |||
| { | |||
There was a problem hiding this comment.
Why does it make this change? identifier is nullable so why the change to empty string?
|
|
||
| #[ORM\Column(type: 'string', length: 255)] | ||
| #[Groups(['mail_template'])] | ||
| private ?string $title = null; |
There was a problem hiding this comment.
Another case of a not nullable property being given type ? and set to null by default. Maybe rector doesn't recognize that properties are not nullable by default? Or perhaps it takes it from the getter which also incorrectly has the return type ?string?
| #[ORM\Column(type: 'string', length: 255)] | ||
| private string $templateFilename; |
There was a problem hiding this comment.
This one seems to be handled differently (but correct!) compared to other properties, so it seems the @var string ensures correctly processing by rector?
| @@ -104,7 +104,7 @@ public function getNextRid() | |||
| foreach ($this->xmlRelationships as $xmlRelationship) { | |||
| $attributes = $xmlRelationship->attributes(); | |||
| if (isset($attributes['Id'])) { | |||
| if ('rId' === substr($attributes['Id'], 0, 3)) { | |||
| if (str_starts_with($attributes['Id'], 'rId')) { | |||
There was a problem hiding this comment.
| private $mockMunicipalityRepository; | ||
| private $propertyAccessor; | ||
| private $documentUploader; | ||
| private \App\Repository\BoardRepository & \PHPUnit\Framework\MockObject\MockObject $mockBoardRepository; |
| */ | ||
| private $assignedCases; | ||
| #[ORM\OneToMany(targetEntity: CaseEntity::class, mappedBy: 'assignedTo')] | ||
| private \Doctrine\Common\Collections\ArrayCollection|array $assignedCases; |
There was a problem hiding this comment.
This will fail if we try loading fixtures. It should probably say \Doctrine\Common\Collections\Collection rather than \Doctrine\Common\Collections\ArrayCollection|array.
Uses Rector to clean up code.
Some annotations are still present.
A commit per change type has been made.