Digital post #402
Merged
Digital post #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimi-itk
force-pushed
the
feature/1015-digital-post
branch
2 times, most recently
from
f5e66df
to
9302812
Compare
rimi-itk
force-pushed
the
feature/1015-digital-post
branch
from
9302812
to
76b166a
Compare
rimi-itk
force-pushed
the
feature/1015-digital-post
branch
2 times, most recently
from
e1e11e7
to
e0921f7
Compare
rimi-itk
force-pushed
the
feature/1015-digital-post
branch
2 times, most recently
from
0fecac1
to
ab02bc0
Compare
rimi-itk
force-pushed
the
feature/1015-digital-post
branch
from
fc1cd28
to
07ff794
Compare
jekuaitk
requested changes
Sep 25, 2024
assets/app.js
Outdated
| const digitalPostAttachmentsInfo = document.querySelector('.digital-post-attachments-info') | ||
| if (digitalPostRecipientWrapper && digitalPostAttachmentsInfo) { | ||
| const recipients = digitalPostRecipientWrapper.querySelectorAll(recipientSelector) | ||
| const updateStuff = () => { |
There was a problem hiding this comment.
Consider renaming although it does indeed update stuff
assets/content/content.scss
Outdated
Comment on lines
16
to
18
| // .tvist1-can-receive-digital-post { | ||
| // color: green; | ||
| // } |
There was a problem hiding this comment.
Suggested change
| // .tvist1-can-receive-digital-post { | |
| // color: green; | |
| // } |
| ForsendelseHelper::FORSENDELSES_TYPE_IDENTIFIKATOR => $this->options['sf1601']['forsendelses_type_identifikator'], | ||
| ]; | ||
| $forsendelse = $this->forsendelseHelper->createForsendelse($digitalPost, $recipient, $forsendelseOptions); | ||
| if (in_array($type, [SF1601::TYPE_DIGITAL_POST, SF1601::TYPE_AUTOMATISK_VALG], true)) { |
There was a problem hiding this comment.
From what i gather $type can enver be SF1601::TYPE_AUTOMATISK_VALG here.
There was a problem hiding this comment.
You're absolutely right, but there's nothing wrong with future-proofing a solution to a problem.
jekuaitk
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://leantime.itkdev.dk/dashboard/home#/tickets/showTicket/1015
Optimizes handling of digital post to make sure that we don't send a superfluously big payload to SF1601's KombiPostAfsend endpoint.
Also contains minor tweaks and fixes to make developers and code analysis tools happy.