Prepare for os2forms 3.16 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimi-itk
reviewed
Sep 26, 2024
.github/workflows/pr.yaml
Outdated
| @@ -23,7 +23,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| php-versions: [ '8.1' ] | |||
| php-versions: [ '8.2' ] | |||
rimi-itk
requested changes
Sep 26, 2024
README.md
Outdated
| @@ -68,8 +68,8 @@ Check coding standards: | |||
|
|
|||
| ```sh | |||
| // PHP CS Fixer | |||
| docker run --rm --interactive --tty --volume ${PWD}:/app itkdev/php8.1-fpm:latest composer install | |||
| docker run --rm --interactive --tty --volume ${PWD}:/app itkdev/php8.1-fpm:latest composer coding-standards-check | |||
| docker run --rm --interactive --tty --volume ${PWD}:/app itkdev/php8.2-fpm:latest composer install | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/tickets/showKanban?search=true&projectId=41&users=21&sprint=all#/tickets/showTicket/2247
Description
Upgrades to Drupal 10 via
os2form/os2forms:^3.16alongside an upgrade to PHP8.3Coding standards
The Drupal coder standard is now case sensitive imports.