Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README with certificate section #2

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Conversation

jekuaitk
Copy link
Collaborator

Link to ticket

https://leantime.itkdev.dk/#/tickets/showTicket/510

Description

Updates README.md with a certificate section.

Screenshot of the result

N/A

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.

Additional comments or questions

N/A

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
jekuaitk and others added 2 commits March 21, 2024 12:37
Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
README.md Outdated
The certificate must be in `pem` or `cer` format and
must be whitelisted by Fasit Schultz.
For this the certificate thumbprint is needed. To get the thumbprint,
in the needed format, from the command line run
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, you told what “the needed format” is. I think you should do that (again) since it's important information.

@jekuaitk jekuaitk requested a review from rimi-itk March 21, 2024 13:02
Copy link
Contributor

@rimi-itk rimi-itk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@jekuaitk jekuaitk merged commit c1ad976 into develop Mar 21, 2024
8 checks passed
@jekuaitk jekuaitk deleted the feature/update-readme branch March 21, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants