generated from itk-dev/itk-base-template-repository
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README with certificate section #2
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jekuaitk
force-pushed
the
feature/update-readme
branch
from
March 20, 2024 09:30
43ccdae
to
7245fd8
Compare
rimi-itk
requested changes
Mar 21, 2024
Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
jekuaitk
force-pushed
the
feature/update-readme
branch
from
March 21, 2024 11:43
b71a695
to
e403f49
Compare
rimi-itk
requested changes
Mar 21, 2024
README.md
Outdated
The certificate must be in `pem` or `cer` format and | ||
must be whitelisted by Fasit Schultz. | ||
For this the certificate thumbprint is needed. To get the thumbprint, | ||
in the needed format, from the command line run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously, you told what “the needed format” is. I think you should do that (again) since it's important information.
rimi-itk
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/#/tickets/showTicket/510
Description
Updates
README.md
with a certificate section.Screenshot of the result
N/A
Checklist
If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.
Additional comments or questions
N/A