Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/loop 735 favourite #18

Merged
merged 9 commits into from
Apr 13, 2021
Merged

Feature/loop 735 favourite #18

merged 9 commits into from
Apr 13, 2021

Conversation

martinyde
Copy link

@martinyde martinyde commented Apr 13, 2021

https://jira.itkdev.dk/browse/LOOP-755

  • Add theming for frontpage displays
  • Add favourite flag
  • Add list display to content types
  • Remove teaser display forom content types
  • Remove titles from view block displays
  • Add view for favourites

@martinyde martinyde requested a review from rimi-itk April 13, 2021 09:53
Copy link

@rimi-itk rimi-itk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have a single question:

What is the effect of changing status: true to status: false in a config file?

@@ -1,6 +1,6 @@
uuid: 6f11cf81-8270-4454-a684-e6fabbf69b35
langcode: en
status: true
status: false

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the effect of this change?

@martinyde martinyde merged commit 463b14e into develop Apr 13, 2021
@martinyde martinyde deleted the feature/LOOP-735-favourite branch April 14, 2021 10:24
rimi-itk pushed a commit that referenced this pull request Apr 20, 2021
rimi-itk pushed a commit that referenced this pull request Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants