LOOP-800: added comments and fixed errors in flaghelper #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimi-itk
added a commit
that referenced
this pull request
Apr 20, 2021
…-helper_04_2021 LOOP-800: added comments and fixed errors in flaghelper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.itkdev.dk/browse/LOOP-800
"I os2loop_upvote modulet ligger FlagHelper-klassen med preprocessField() metoden. Denne metode har en ret høj kodekompleksitet med mange betingelser og løkker nested i hinanden. Dette nedsætter læsbarheden og øger risikoen for fejl i funktionaliteten, samt øger risikoen for at der ved videreudvikling introduceres nye fejl eller utilsigtet, ændret logik.
Der er muligvis allerede en fejl i metoden idet nedenstående linje muligvis kan udføres uden der er identificeret / sat en $top_comment. Om det i praksis er et problem skal jeg ikke kunne sige, men det illustrerer meget fint hvorfor det kan være en idé at arbejde med metoden så den bliver mere læsbar.
Samlet set er metoden dog ikke omfattende hvilket afbøder risikoen en smule."