FORMS-674: Search #24
Conversation
rimi-itk
force-pushed
the
feature/FORMS-674-search
branch
from
7faacd3
to
cdb4dd7
Compare
rimi-itk
force-pushed
the
feature/FORMS-674-search
branch
from
cdb4dd7
to
7fc9d6e
Compare
rimi-itk
force-pushed
the
feature/FORMS-674-search
branch
from
7fc9d6e
to
b9bae6d
Compare
rimi-itk
force-pushed
the
feature/FORMS-674-search
branch
2 times, most recently
from
cc6ef2f
to
e1b9c86
Compare
rimi-itk
force-pushed
the
feature/FORMS-674-search
branch
from
e1b9c86
to
dcfca09
Compare
rimi-itk
force-pushed
the
feature/FORMS-674-search
branch
from
30cd023
to
65a648d
Compare
rimi-itk
force-pushed
the
feature/FORMS-674-search
branch
from
1f5ce09
to
02ff5a9
Compare
| ## Example: Find Organisation by CVR number | ||
|
|
||
| ```php | ||
|
|
There was a problem hiding this comment.
Should we add a working example here?
There was a problem hiding this comment.
Yes … when we have a working example …
src/Service/SF1500/BrugerService.php
Outdated
| $model->brugertype = $egenskab->getBrugerTypeTekst(); | ||
| } | ||
| foreach ($registrering->getRelationListe()->getAdresser() as $adresse) { | ||
| // TODO |
There was a problem hiding this comment.
Is there still more todo here?
There was a problem hiding this comment.
I don't know yet. I don't know if the models will be useful.
rimi-itk
force-pushed
the
feature/FORMS-674-search
branch
from
d72d8b7
to
8d0cdbc
Compare
rimi-itk
force-pushed
the
feature/FORMS-674-search
branch
from
8d0cdbc
to
f0233ce
Compare
src/Service/SF1500/BrugerService.php
Outdated
| $organisationFunktioner = $service->soeg([ | ||
| OrganisationFunktionService::FILTER_FUNKTIONSTYPEID => $this->options['organisation-funktion-manager-id'] | ||
| ]); |
There was a problem hiding this comment.
Could we end up in a scenario where this list is not exhaustive?
There was a problem hiding this comment.
I'm not sure I understand this question. We want to search for a specific type (id) and therefore search, i.e. filter, only on OrganisationFunktionService::FILTER_FUNKTIONSTYPEID.
src/Service/SF1500/BrugerService.php
Outdated
| foreach ($registrering->getAttributListe()->getEgenskab() as $egenskab) { | ||
| $model->brugernavn = $egenskab->getBrugerNavn(); | ||
| $model->brugertype = $egenskab->getBrugerTypeTekst(); | ||
| } |
There was a problem hiding this comment.
Do we unintentionally overwrite brugernavn and brugertype here?
There was a problem hiding this comment.
Not unintentionally, but we assume that we have only a single item in the attribute list. I'll add a clarifying comment.
src/Service/SF1500/BrugerService.php
Outdated
| $model->brugertype = $egenskab->getBrugerTypeTekst(); | ||
| } | ||
| foreach (($registrering->getRelationListe()->getAdresser() ?? []) as $adresse) { | ||
| $model->setRelation( |
There was a problem hiding this comment.
setRelation to me makes it seem it is overwritten for each $adresse when in fact it adds to a list of relations. Should we rename to addRelation?
There was a problem hiding this comment.
I'll add a clarifying comment.
https://jira.itkdev.dk/browse/FORMS-674