used RWMutex instead of Mutex

admiral/pkg/controller/admiral/service.go

@@ -36,7 +36,7 @@ type ServiceController struct {
 type serviceCache struct {
 	//map of dependencies key=identity value array of onboarded identities
 	cache map[string]*ServiceClusterEntry
-	mutex *sync.Mutex
+	mutex *sync.RWMutex
 }
 
 func (s *serviceCache) Put(service *k8sV1.Service) {
@@ -71,8 +71,8 @@ func (s *serviceCache) getKey(service *k8sV1.Service) string {
 }
 
 func (s *serviceCache) Get(key string) *ServiceClusterEntry {
-	s.mutex.Lock()
-	defer s.mutex.Unlock()
+	s.mutex.RLock()
+	defer s.mutex.RUnlock()
 	return s.cache[key]
 }
 
@@ -121,7 +121,7 @@ func NewServiceController(stopCh <-chan struct{}, handler ServiceHandler, config
 
 	podCache := serviceCache{}
 	podCache.cache = make(map[string]*ServiceClusterEntry)
-	podCache.mutex = &sync.Mutex{}
+	podCache.mutex = &sync.RWMutex{}
 
 	serviceController.Cache = &podCache
 	var err error

admiral/pkg/controller/admiral/service_test.go

@@ -40,7 +40,7 @@ func TestNewServiceController(t *testing.T) {
 func TestServiceCache_Put(t *testing.T) {
 	serviceCache := serviceCache{}
 	serviceCache.cache = make(map[string]*ServiceClusterEntry)
-	serviceCache.mutex = &sync.Mutex{}
+	serviceCache.mutex = &sync.RWMutex{}
 
 	//test service cache empty with admiral ignore should skip to save in cache
 
@@ -93,7 +93,7 @@ func TestServiceCache_Put(t *testing.T) {
 func TestServiceCache_GetLoadBalancer(t *testing.T) {
 	sc := serviceCache{}
 	sc.cache = make(map[string]*ServiceClusterEntry)
-	sc.mutex = &sync.Mutex{}
+	sc.mutex = &sync.RWMutex{}
 
 	service := &v1.Service{}
 	service.Name = "test-service"
@@ -246,7 +246,7 @@ func TestServiceCache_GetLoadBalancer(t *testing.T) {
 func TestConcurrentGetAndPut(t *testing.T) {
 	serviceCache := serviceCache{}
 	serviceCache.cache = make(map[string]*ServiceClusterEntry)
-	serviceCache.mutex = &sync.Mutex{}
+	serviceCache.mutex = &sync.RWMutex{}
 
 	serviceCache.Put(&v1.Service{
 		ObjectMeta: metaV1.ObjectMeta{Name: "testname", Namespace: "testns"},