Skip to content

Commit

Permalink
Add --no-cache-dir to prevent false positives of PEP-517 support.
Browse files Browse the repository at this point in the history
When trying to determine if the issue was because of Poetry or the package not supporting PEP-517 mode, it is possible that the pip cache can result in false positives of packages that support PEP-517. An example of this is the issue python-poetry#8462. 

This PR adds to the error output and recommended command to prevent this from happening in the future.

As a new user to Python, it wasn't immediately obvious to me when running on the command line why it succeeded, and simply took that it did as enough confirmation that opening an issue was valid.
  • Loading branch information
itsjamie authored Sep 22, 2023
1 parent 515a763 commit 3c3a2a7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/poetry/installation/executor.py
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ def _execute_operation(self, operation: Operation) -> None:
" and is likely not a problem with poetry"
f" but with {pkg.pretty_name} ({pkg.full_pretty_version})"
" not supporting PEP 517 builds. You can verify this by"
f" running '{pip_command} \"{requirement}\"'."
f" running '{pip_command} --no-cache-dir \"{requirement}\"'."
"</info>"
)
elif isinstance(e, SolverProblemError):
Expand Down

0 comments on commit 3c3a2a7

Please sign in to comment.