This repository has been archived by the owner on Jun 5, 2020. It is now read-only.
Update iconpicker.less #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using 6px as margin at the `.icon-picker-item` will result in 4 columns of icons instead of 3.
|
Thanks, but actually the icons are displayed in rows of 4 currently. Also having 6px of margin will lead into design inconsistencies. The |
|
This is how it looks like on Chrome 64 + Mac OS after applying your changes:
|
|
In FireFox, the scrollbar is showing in all examples. This leaves less space for the icons causing them to display in 3 columns. |
|
I did not download any version yet, this was the case on the current example page. So I did not download it because of that (yet) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using 6px as margin at the
.icon-picker-itemwill result in 4 columns of icons instead of 3.