Fix the stack overflow issue from Const.Randomized #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The bug with const was that it should give a singleton - The singleton (finite streams) have exposed a bug in toGen (that now might need to work with a finite stream) - This also exposed the memory leak more clearly, which *might* be related to conversion of Java Streams to scala streams in a not stack friendly manner. This allowed me to handle 300K episodes for SimpleMaze. Likely avoiding flatMap in agent implementations might help as well.
This bug was introduced in this PR (when we switched to unfold), so we want to fix it on spot.
The bump to 400K was committed by mistake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes are kept in issue #53