Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source dir override for /plugins, /mods, and /config #1957

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Add source dir override for /plugins, /mods, and /config #1957

merged 2 commits into from
Feb 9, 2023

Conversation

rhullah
Copy link
Contributor

@rhullah rhullah commented Feb 7, 2023

Requested in Discord. Adds two environment variables to allow the override of the /mods and /config source directories.

  • COPY_MODS_SRC
  • COPY_CONFIG_SRC

Additionally adds a "setup only" test for this scenario.

@rhullah
Copy link
Contributor Author

rhullah commented Feb 7, 2023

I did not add one for /plugins source because there wasn't an existing one for the /plugins destination. I can add a COPY_PLUGINS_SRC (and COPY_PLUGINS_DEST) if you feel it's needed.

@itzg
Copy link
Owner

itzg commented Feb 7, 2023

I did not add one for /plugins source because there wasn't an existing one for the /plugins destination. I can add a COPY_PLUGINS_SRC (and COPY_PLUGINS_DEST) if you feel it's needed.

Thanks for catching that. To be consistent with mods, it does make sense to add COPY_PLUGINS_SRC.

FWIW, COPY_MODS_DEST seems like overkill now that I think about it.

Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks great and I'll merge when the plugins variable is ready.

@rhullah
Copy link
Contributor Author

rhullah commented Feb 8, 2023

Thanks for catching that. To be consistent with mods, it does make sense to add COPY_PLUGINS_SRC.

Would you like both COPY_PLUGINS_SRC and COPY_PLUGINS_DEST, or just the SRC?

@rhullah
Copy link
Contributor Author

rhullah commented Feb 8, 2023

I assumed both and added them. If you only want SRC, I can remove DEST.

@rhullah rhullah changed the title Add source dir override for /mods and /config Add source dir override for /plugins, /mods, and /config Feb 8, 2023
Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Adding both was great for completeness.

@itzg itzg merged commit fd2dfe3 into itzg:master Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants