Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use modified knockd to set a cooldown on port 19132 #2003

Merged
merged 7 commits into from
Mar 12, 2023

Conversation

Metalcape
Copy link
Contributor

Fixes #1969.

There are a couple details that may need to be addressed:

  • seq_cooldown can't be bigger than AUTOPAUSE_TIMEOUT_KN (see last commit). We might want to set a lower bound for both, or expose the cooldown timer as an environment variable.
  • I have no idea if the libpcap package has the same name for dnf and alpine, I know that apt has libpcap0.8 but the other scripts may have to be changed.

@Metalcape Metalcape changed the title Use modified knock to set a cooldown on port 19132 (#1969) Use modified knockd to set a cooldown on port 19132 (#1969) Mar 11, 2023
@Metalcape Metalcape changed the title Use modified knockd to set a cooldown on port 19132 (#1969) Use modified knockd to set a cooldown on port 19132 Mar 11, 2023
build/ol/install-packages.sh Outdated Show resolved Hide resolved
Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

Ready for this to merge?

@Metalcape
Copy link
Contributor Author

Yes, nothing to add if all looks good.

@itzg itzg merged commit e217ac5 into itzg:master Mar 12, 2023
@Metalcape Metalcape deleted the bedrock-knockd-fix branch March 12, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server does not resume from autopause when port is knocked
2 participants