Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added docs to use env file #2054

Merged
merged 2 commits into from
Mar 30, 2023
Merged

added docs to use env file #2054

merged 2 commits into from
Mar 30, 2023

Conversation

camalot
Copy link
Contributor

@camalot camalot commented Mar 30, 2023

documents #2048

README.md Outdated
> ```yaml
> minecraft:
> env_file:
> - ./minecraft-server.env
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually .env is a special file that doesn't even need to be called out specifically:

https://docs.docker.com/compose/environment-variables/set-environment-variables/#substitute-with-an-env-file

I'm leaning towards that one being documented with just the api key and showing all the other variables can be in the compose file like normal.

I can be easily convinced otherwise since docker run still needs the env file specifically mentioned.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a good point, i will indicate .env.

@camalot
Copy link
Contributor Author

camalot commented Mar 30, 2023

Updated the doc to, hopefully, explain how to use a .env.

Might want to consider changing for a single readme to use the wiki in github. can then break things down by server type, and such, so its not all in 1 huge file. but it does make it easier to find things with CTRL+F if you sort of know what you're looking for. ¯\(ツ)

@itzg
Copy link
Owner

itzg commented Mar 30, 2023

Might want to consider changing for a single readme to use the wiki in github. can then break things down by server type, and such, so its not all in 1 huge file. but it does make it easier to find things with CTRL+F if you sort of know what you're looking for. ¯_(ツ)_/¯

Indeed! There's been an open issue forever that I momentarily think about and then get overwhelmed 😀

Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Thanks again!

@itzg itzg merged commit 0d5e44a into itzg:master Mar 30, 2023
@camalot
Copy link
Contributor Author

camalot commented Mar 30, 2023

Indeed! There's been an open issue forever that I momentarily think about and then get overwhelmed 😀

If you have any idea of the structure, and what not, and want to create that wiki branch, i would be more than willing to help moving the docs.

@itzg
Copy link
Owner

itzg commented Mar 30, 2023

I was originally thinking of just using the wiki mechanism. What are your thoughts about that vs a documentation site generator like the I found for the issue: https://squidfunk.github.io/mkdocs-material/ ?

@camalot camalot deleted the env-file-docs branch March 30, 2023 22:50
@camalot
Copy link
Contributor Author

camalot commented Mar 30, 2023

I am not familiar with the mkdocs. I will look it over. high level, just looks like markdown files. only thing i can think of from a user standpoint is not having built-in navigation in github. but you could also just link to the docs, and make github specifically for the more technical side of it, like the code, issues, and discussions

@itzg
Copy link
Owner

itzg commented Mar 30, 2023

I have zero experience with that tool also 😀, so am more pondering the overall user experience of the "documentation site" tools vs github wiki.

camalot added a commit to camalot/docker-minecraft-server that referenced this pull request Mar 31, 2023
* master:
  Auto CurseForge, added docs to use env file (itzg#2054)
camalot added a commit to camalot/docker-minecraft-server that referenced this pull request Apr 4, 2023
* master:
  Tweak level of new docs link (itzg#2063)
  updated the readme to include the link to the docs site. (itzg#2061)
  Update CF_API_KEY example for docker run (itzg#2060)
  With AUTO_CURSEFORGE handle modpacks not allowed for distribution by author (itzg#2059)
  Redacts sensitive headers from debugs like with AUTO_CURSEFORGE (itzg#2058)
  Downloads handle content disposition filename with RFC 2047 encoding (itzg#2057)
  Auto CurseForge, added docs to use env file (itzg#2054)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants