Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: removed duplicated RCON_CMDS variable #3072

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Conversation

omarx11
Copy link
Contributor

@omarx11 omarx11 commented Sep 16, 2024

Removed duplicated RCON_CMDS_STARTUP

Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the original contributor left out RCON_CMDS_FIRST_CONNECT and maybe the duplicate was a copy-paste to get ready for it

https://docker-minecraft-server.readthedocs.io/en/latest/configuration/auto-rcon-commands/

Do you mind fixing it that way?

@omarx11
Copy link
Contributor Author

omarx11 commented Sep 16, 2024

It looks like the original contributor left out RCON_CMDS_FIRST_CONNECT and maybe the duplicate was a copy-paste to get ready for it

https://docker-minecraft-server.readthedocs.io/en/latest/configuration/auto-rcon-commands/

Do you mind fixing it that way?

Thank you for pointing that out. I understand now that the original contributor might have intended to include RCON_CMDS_FIRST_CONNECT. I'll make the necessary changes and add RCON_CMDS_FIRST_CONNECT with the appropriate description to the documentation. I'll update the pull request shortly.

Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@itzg itzg changed the title docs: removed duplicated variable docs: removed duplicated RCON_CMDS variable Sep 16, 2024
@itzg itzg merged commit 295996b into itzg:master Sep 16, 2024
1 check passed
sevenrats pushed a commit to sevenrats/docker-minecraft-server that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants