refactoring a little bit some test script files #3100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll review the changes more thoroughly, but so far I like what I see. Was there a particular problem you were solving? Or just wanted to contribute some code cleanup? |
|
Thank you for the feedback! I’m eager to contribute more to this project. My main goal was to learn how it works, and I noticed some areas that could use a bit of code cleanup. I thought it would be a good way to start my first PR. I wasn’t addressing a specific issue; I just wanted to make a contribution and get involved. Looking forward to your thoughts! |
itzg
reviewed
Oct 13, 2024
Co-authored-by: Geoff Bourne <itzgeoff@gmail.com>
sevenrats
pushed a commit
to sevenrats/docker-minecraft-server
that referenced
this pull request
Nov 19, 2024
Co-authored-by: Geoff Bourne <itzgeoff@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.