Fix mc-send-to-console running with uid=0(root) #3106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change the permission to exec pipe.
itzg
reviewed
Oct 14, 2024
change the get uid ways.
|
i found the pipe |
itzg
reviewed
Oct 15, 2024
Co-authored-by: Geoff Bourne <itzgeoff@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an error in the conditional statement
if [ "$(id -u)" != 0 ]; then.This condition incorrectly allows the ‘minecraft’ user to access the pipe
/tmp/minecraft-console-inwhen the UID is 0 (i.e., when running as the root user), resulting in permission errors.This pull request corrects the erroneous check.