Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename MOD_PLATFORM to MODPACK_PLATFORM #3120

Merged
merged 9 commits into from
Oct 24, 2024
Merged

Rename MOD_PLATFORM to MODPACK_PLATFORM #3120

merged 9 commits into from
Oct 24, 2024

Conversation

IronMine
Copy link
Contributor

itzg
itzg reviewed Oct 21, 2024
View reviewed changes
Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn’t want to penalize users for still using MOD_PLATFORM. I just wanted to add the new variable going forward and alias the old variable to it. In the docs I wanted it to say that either is fine.

And we talked about large PRs 😬

@IronMine
Copy link
Contributor Author

IronMine commented Oct 21, 2024 •
edited
Loading

Okay sorry i misunderstood the description of what you wanted 😅 i know about the large PR but since it's only a rename of a variable i tought it was okay mb !

itzg
itzg reviewed Oct 22, 2024
View reviewed changes
Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the changes I'd like to see.

I do want to thank you for helping out on the project and I hope I haven't scared you off with both sets of PR feedback.

docs/types-and-platforms/index.md Outdated Show resolved Hide resolved
docs/types-and-platforms/mod-platforms/auto-curseforge.md Outdated Show resolved Hide resolved
docs/types-and-platforms/mod-platforms/curseforge.md Outdated Show resolved Hide resolved
docs/types-and-platforms/mod-platforms/ftb.md Outdated Show resolved Hide resolved
docs/types-and-platforms/mod-platforms/modrinth-modpacks.md Outdated Show resolved Hide resolved
scripts/start-configuration Outdated Show resolved Hide resolved
scripts/start-configuration Outdated Show resolved Hide resolved
scripts/start-configuration Outdated Show resolved Hide resolved
itzg
itzg reviewed Oct 22, 2024
View reviewed changes
scripts/start-configuration Outdated
@@ -160,7 +160,7 @@ fi

: "${MODPACK_PLATFORM:=${MOD_PLATFORM:-}}"

if [[ $MODPACK_PLATFORM -a $TYPE ]]; then
if [[ -z $MODPACK_PLATFORM || -z $TYPE ]]; then
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks more confusing now. Sorry for my wrong suggestion initially, but can you use this instead to get back to my original intent:

Suggested change
if [[ -z $MODPACK_PLATFORM || -z $TYPE ]]; then
if [[ $MODPACK_PLATFORM && $TYPE ]]; then

itzg
itzg reviewed Oct 23, 2024
View reviewed changes
Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in the re-review. Just one last tweak and it'll be good to merge.

scripts/start-configuration Outdated Show resolved Hide resolved
@itzg itzg linked an issue Oct 24, 2024 that may be closed by this pull request
Rename MOD_PLATFORM to MODPACK_PLATFORM #3115
Closed
@itzg itzg merged commit e69ee85 into itzg:master Oct 24, 2024
5 checks passed
@itzg itzg changed the title #3115 rename MOD_PLATFORM to MODPACK_PLATFORM Rename MOD_PLATFORM to MODPACK_PLATFORM Oct 24, 2024
@itzg itzg mentioned this pull request Oct 24, 2024
Merged
sevenrats pushed a commit to sevenrats/docker-minecraft-server that referenced this pull request Nov 19, 2024
@IronMine @sevenrats
itzg#3115 rename MOD_PLATFORM to MODPACK_PLATFORM (itzg#3120)
2c557f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itzg itzg itzg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename MOD_PLATFORM to MODPACK_PLATFORM
2 participants
@IronMine @itzg