fix start-deployFTBA #3124
Merged
fix start-deployFTBA #3124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
let me check just to be sure ! |
itzg
reviewed
Oct 26, 2024
scripts/start-deployFTBA
Outdated
| @@ -45,7 +45,7 @@ if isTrue "$FTB_FORCE_REINSTALL" || ! [ -f "${ftbInstallMarker}" ] || [ "$(cat " | |||
| log "Downloading FTB installer" | |||
| if [ "$(uname -m)" == "aarch64" ]; then | |||
| log "Downloading ARM installer" | |||
| $arm=/arm | |||
| $arm="/arm" | |||
There was a problem hiding this comment.
And remove that leading $ I think
(Some languages include that there so now I'm getting myself confused 😀)
There was a problem hiding this comment.
yes because i was doing some php ealier this day :/
|
really sorry for that i should have tested this ! But this makes me want to add a lot more tests ^^ |
No problem at all. Take a look at the setuponly tests if you're interested...however, it's a balancing act since too many of them ran fairly slow. |
itzg
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes : #3123