Skip to content

Add helm charts #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add helm charts #460

wants to merge 1 commit into from

Conversation

sfxworks
Copy link
Contributor

@sfxworks sfxworks commented Mar 23, 2020

As a submodule since I plan to do a lot with prow and CI.

Relates to #362

  • k8s deployment by referencing simplified values
  • Compatible with helm 3
  • Deploys service type NodePort and encourages SRV records instead of 1 server per IP models
  • Will include future updates like SSH and Web for the Dynmap / web of things
2m41s       Normal    SuccessfulCreate       statefulset/chart-1584956837                 create Pod chart-1584956837-0 in StatefulSet chart-1584956837 successful
<unknown>   Normal    Scheduled              pod/chart-1584956837-0                       Successfully assigned test/chart-1584956837-0 to a6
2m40s       Normal    Pulled                 pod/chart-1584956837-0                       Container image "docker.io/itzg/minecraft-server:adopt13" already present on machine
2m40s       Normal    Created                pod/chart-1584956837-0                       Created container chart-1584956837
2m40s       Normal    Started                pod/chart-1584956837-0                       Started container chart-1584956837
101s        Warning   Unhealthy              pod/chart-1584956837-0                       Readiness probe failed: server not ready localhost:25565
<unknown>   Normal    Scheduled              pod/chart-1584956837-connection-test-flk9x   Successfully assigned test/chart-1584956837-connection-test-flk9x to a6
29s         Normal    Pulling                pod/chart-1584956837-connection-test-flk9x   Pulling image "itzg/mc-monitor:0.5.0"
22s         Normal    Pulled                 pod/chart-1584956837-connection-test-flk9x   Successfully pulled image "itzg/mc-monitor:0.5.0"
22s         Normal    Created                pod/chart-1584956837-connection-test-flk9x   Created container main
22s         Normal    Started                pod/chart-1584956837-connection-test-flk9x   Started container main
30s         Normal    SuccessfulCreate       job/chart-1584956837-connection-test         Created pod: chart-1584956837-connection-test-flk9x
PS C:\Users\shaba\Documents\git\mcsh-charts\server-deployment> helm install . --wait --generate-name
NAME: chart-1584956837
LAST DEPLOYED: Mon Mar 23 05:47:18 2020
NAMESPACE: test
STATUS: deployed
REVISION: 1
PS C:\Users\shaba\Documents\git\mcsh-charts\server-deployment> helm test chart-1584956837
NAME: chart-1584956837
LAST DEPLOYED: Mon Mar 23 05:47:18 2020
NAMESPACE: test
STATUS: deployed
REVISION: 1
TEST SUITE:     chart-1584956837-connection-test
Last Started:   Mon Mar 23 05:49:29 2020
Last Completed: Mon Mar 23 05:49:43 2020
Phase:          Succeeded

Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this, but I would prefer not to bring a submodule into the repository. Please review my suggestion from the issue

I think it would be great to have a "Deployment Examples" (or something like that) section in the README that would list sources like yours along with the server-only Helm chart https://github.com/helm/charts/tree/master/stable/minecraft . Selfishly, I can also throw in my not-so-elegant kubernetes deployment file I copy-tweak-paste :)

Additionally, I just discovered Helm Hub has a process to submit additional chart repos into their Hub. I would recommend pursuing that and then the new "Deployment Examples" section that provide helm instructions to utilize that:

https://github.com/helm/hub/blob/master/Repositories.md

@sfxworks
Copy link
Contributor Author

That will take some time since I'd have to alter it a bit more/await helm/repo/charts for PR approval, but I could do that! Sounds like a plan.

@itzg
Copy link
Owner

itzg commented Mar 24, 2020

Thanks. If it helps I could create a starter README in the examples directory that in turn can be referenced from the top of the main README. I think a small paragraph with a link to your repo https://github.com/mcserverhosting-net/charts would be sufficient since you then provide all the helm repo operations a user would need there.

@sfxworks
Copy link
Contributor Author

That would be great! I have the week off so I'm planning to continue working on the charts throughout.

@itzg
Copy link
Owner

itzg commented Mar 24, 2020

Can you see if #461 works for you?

@itzg
Copy link
Owner

itzg commented Aug 9, 2020

I am going to close this since official Helm charts have since been moved to https://github.com/itzg/minecraft-server-charts

@itzg itzg closed this Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants