Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mc-pinger dependency supports Timeouts #3

Open
Herobone opened this issue Feb 22, 2021 · 1 comment
Open

mc-pinger dependency supports Timeouts #3

Herobone opened this issue Feb 22, 2021 · 1 comment

Comments

@Herobone
Copy link

The mc-pinger dependency has been updated and now supports Timeouts and Contexts.
Maybe have a look at it, so that the java status command can fail after a certain time.
Currently the command will try to connect to the server indefinitely even if the server is offline.

If you don't have time I could also implement the feature and open a pull request. Just let me know if you would like to support this feature
@itzg
Copy link
Owner

itzg commented Feb 22, 2021

Thanks for adding that over there. Yes, a PR to integrate that in here would be great.

@Herobone Herobone mentioned this issue Feb 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@itzg @Herobone