Add Timeout support for Java Ping #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itzg
reviewed
Feb 23, 2021
Co-authored-by: Geoff Bourne <itzgeoff@gmail.com>
itzg
approved these changes
Feb 23, 2021
|
I will try to implement the rest. But maybe it would be more useful to open a new request for that, if it does not work |
I'm good with that since what you have is already a great help. |
|
Oops, apparently I don't have automated test builds setup for PRs. The merge to master reported a mismatch in the new field |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the code that shows a possible execution of #3
I so far only added it to one command, could add it to the others if required, but I'm not familiar with Prometheus or Telegraf
Dependencies were updated. No problems on my end with that. Update was not intentional, just triggered automatically by IDE