Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add subPath support for dataDir and backupDir #185

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

seanb4t
Copy link

@seanb4t seanb4t commented Jan 3, 2024

Adding in support for specifying a subPath of a given volume to use for backup and dataDir ( partial support was already there for dataDir )

Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! Please also bump the chart's minor version and this will be good to go.

@billimek
Copy link
Collaborator

billimek commented Jan 3, 2024

It's probably also worthwhile adding a comment to the values.yaml file for the Values.mcbackup.persistence.backupDir section indicating that subPath is now an option.

@itzg
Copy link
Owner

itzg commented Jan 3, 2024

Agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants