Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix secret name for RCON password in proxy #196

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Conversation

bastibrunner
Copy link
Contributor

Fixed secret reference name in deployment, there's no "-rcon" appended in the secret's template.

@itzg itzg changed the title Fix secret name Fix secret name for RCON password in proxy Apr 11, 2024
@itzg
Copy link
Owner

itzg commented Apr 11, 2024

@toddejohnson can you help review this change since you introduced the original with #189

Copy link
Contributor

@toddejohnson toddejohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing! Not going to lie... I stole most that from:

name: {{ .Values.minecraftServer.rcon.existingSecret | default (printf "%s-rcon" (include "minecraft.fullname" .)) }}

{{- if not .Values.minecraftServer.rcon.existingSecret }}

In the secret I just wrapped it in the if to conditionally create it if it didn't exist. It does look like I forgot to pull over the -rcon. Great catch @bastibrunner!

@itzg
Copy link
Owner

itzg commented Apr 11, 2024

Thanks for looking at it, @toddejohnson

Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let me know if you're ready for that to be merged.

@toddejohnson
Copy link
Contributor

Looks good to me!

@itzg itzg merged commit 45e46ae into itzg:master Apr 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants