Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CF_API_KEY on other server types e.g. PAPER, SPIGOT #197

Merged
merged 3 commits into from
May 22, 2024

Conversation

Tuxprogrammer
Copy link
Contributor

@Tuxprogrammer Tuxprogrammer commented Apr 13, 2024

Create CF_API_KEY resource on other server types to allow for CURSEFORGE_FILES auto download mods.

I'd like to use Curseforge auto downloader to download bukkit mods like: https://www.curseforge.com/minecraft/bukkit-plugins/worldedit

This works without needing to copy them out of mods folder. mc-image-helper knows to put them in plugins/ folder automatically.

Log Snippet

[mc-image-helper] 05:44:47.786 INFO  : Downloaded mod file plugins/worldedit-bukkit-7.3.0.jar

create CF_API_KEY resource on other server types to allow for CURSEFORGE_FILES auto download mods.
Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find. It seems like a whole new value section should be introduced for https://docker-minecraft-server.readthedocs.io/en/latest/mods-and-plugins/curseforge-files/ since that can be used independently of the Auto CurseForge modpack/platform type.

Or are you passing those via the extraEnv get at the API key secret part of the deployment template?

@Tuxprogrammer
Copy link
Contributor Author

Yes, I am using the CURSEFORGE_FILES environment.

https://github.com/Tuxprogrammer/homelab/blob/master/kubernetes%2Fapps%2Fminecraft%2Fjava%2Fvanilla%2Fvalues.yaml

That's the specific values for the most part that I'm using.

Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the chart version and then I'm good to merge this.

@itzg itzg merged commit 9cfee6e into itzg:master May 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants