Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colorization #12

Merged
merged 3 commits into from
Sep 29, 2021
Merged

Add colorization #12

merged 3 commits into from
Sep 29, 2021

Conversation

bram-pkg
Copy link
Contributor

@bram-pkg bram-pkg commented Sep 28, 2021

Fixed #4

Disabled on Windows for now, but it's a good initial working version.

I've also added a small docker-compose.yml file to test rcon-cli easily.

Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic contribution. Just the variable name tweak and I'll get this merged and updated in the image.

cli/entry.go Show resolved Hide resolved
cli/entry.go Outdated Show resolved Hide resolved
@itzg itzg merged commit b39477a into itzg:master Sep 29, 2021
@bram-pkg bram-pkg deleted the add-color-support branch September 29, 2021 14:23
@itzg
Copy link
Owner

itzg commented Sep 29, 2021

After getting some CI changes fixed up, your change is included in https://github.com/itzg/rcon-cli/releases/tag/1.5.1

@itzg
Copy link
Owner

itzg commented Sep 29, 2021

and it is now included in the latest itzg/minecraft-server image

@bram-pkg
Copy link
Contributor Author

Thanks man, you're so quick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symbol / Text / Unicode Issues with Spigot / Bukkit Console?
2 participants