Fixed MSVC C3872 compiler errors by replacing the Greek alphabet symbols with their corresponding English names #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls with their corresponding English names. Compiling the current code as it is using MSVC 2022 throws a lot of C3872 compiler errors such as "error C3872: '0x2030': this character is not allowed in an identifier". This is due to the fact that the MSVC compiler 'follows the C++11 standard on characters allowed in an identifier'. See https://learn.microsoft.com/en-us/cpp/error-messages/compiler-errors-2/compiler-error-c3872?view=msvc-170. The issue is resolved by replacing the Greek alphabet symbols with their corresponding English names.
Owner
|
Hi @ElMostafaIdrassi thanks for the PR, I'll try to review them soon. |
Owner
|
In the mean time, I'll let the CI run. |
itzmeanjan
requested changes
Jun 24, 2025
…plate parameter eta
…iginal code logic
itzmeanjan
requested changes
Jun 24, 2025
Owner
|
You can locally run tests before pushing to your branch, that way you should be able to avoid many of these issues. Have a look at the README for how to run tests. |
Contributor
Author
|
Tests seem to be passing locally |
itzmeanjan
requested changes
Jun 25, 2025
itzmeanjan
approved these changes
Jun 26, 2025
Owner
itzmeanjan
left a comment
itzmeanjan
left a comment
There was a problem hiding this comment.
Looks good. Thanks @ElMostafaIdrassi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling the current code using
MSVC 2022throws a lot ofC3872compiler errors such as:error C3872: '0x2030': this character is not allowed in an identifierfor theωsymbol for example.This is due to the fact that the
MSVCcompilerfollows the C++11 standard on characters allowed in an identifier: see Microsoft documentationThe issue is resolved by replacing the Greek alphabet symbols with their corresponding English names.