Fixed MSVC C4146 compiler warning/error by using binary subtraction instead of unary minus #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f unary minus on unsigned.
Owner
|
Thanks again for the PR, I'll have a look. For now running the CI. |
Owner
|
Looks good, merging it. Thanks for addressing the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVCemitsC4146on the(- static_cast<uint32_t>(flg0)) & mask13;and-(t0 >> 31)expressions in thebarrett_reduce()andreduce_once()functions respectively, despite them being valid two’s-complement negations.If the
/sdloption is enabled (which is by default inMSVC 2022), this warning becomes an error.By replacing the unary minus with an explicit unsigned subtraction, we can silence the warnings/errors while preserving the constant-expression, branchless behavior.