Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a
loadingStates
property in the datastore, which is an observableMap
object keyed by a query tag, and with values of sets of query information that is added and removed as fetches start / complete.Previously, the
Map
andSet
were initialized separately, with theSet
initialized as ashallow
observable so that its objects would not be observable, and thus would not be proxied objects and could be compared directly.However, because mobx propagates observability down, this seems to have broken after a recent change in a mobx Typescript interceptor
This PR changes the data structure to initialize observability once, and change the query reference objects to JSON strings so that they will not be proxied themselves.