-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zh/add search bar #69
base: dev
Are you sure you want to change the base?
Conversation
Kudos, SonarCloud Quality Gate passed! |
When hovering over the filter icon, the word filter should show up. |
Difficulty should be able to be seen by everyone. Its a tightly coupled feature, thus it is ok that it is big. We just do not want multiple different things in the same PR or all PRs to be this big. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
eb9a611
to
2d225ec
Compare
Kudos, SonarCloud Quality Gate passed! |
# Conflicts: # src/redux/selectors/entities.ts
Kudos, SonarCloud Quality Gate passed! |
This PR adds modules search and filter, tested on all user roles. The backend PR for this (ius-csg/cslabs-backend#61).
Full-text search is performed on name and description.
Couple concerns:
Below are examples:
Search:
modules-search.mp4
Filter:
module-filter.mp4