Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zh/add search bar #69

Open
wants to merge 28 commits into
base: dev
Choose a base branch
from
Open

Zh/add search bar #69

wants to merge 28 commits into from

Conversation

zkhussain
Copy link
Contributor

@zkhussain zkhussain commented Sep 22, 2021

This PR adds modules search and filter, tested on all user roles. The backend PR for this (ius-csg/cslabs-backend#61).
Full-text search is performed on name and description.

  • User can do a basic search which matches name, description, and tag names.
  • User can search with options, which matches the results on multiple matching input fields, at least one is required to see search results.
  • A user can see the search inputs inside tags in the search bar above it.
  • A user can filter through modules, additionally admins can sort by their modules and type.
  • A user can only select one sorting option, I had it to filter through multiple options, but some combinations don't make sense such as name and difficulty.

Couple concerns:

  • Should non-creators be able to see module difficulty? Currently, I have it after date, let me know if that needs to be changed.
  • The ModulesSearch component became a little large, I tried separating it, but some things were not working out, and I think it's still straight forward. Let me know if I should separate it.

Below are examples:

Search:

modules-search.mp4

Filter:

module-filter.mp4

@zkhussain zkhussain requested a review from jasekiw September 22, 2021 02:13
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@zkhussain zkhussain mentioned this pull request Nov 4, 2021
@zkhussain zkhussain marked this pull request as ready for review January 4, 2022 23:09
@Cliftonz
Copy link
Member

Cliftonz commented Jan 4, 2022

When hovering over the filter icon, the word filter should show up.

@Cliftonz
Copy link
Member

Cliftonz commented Jan 4, 2022

Difficulty should be able to be seen by everyone.

Its a tightly coupled feature, thus it is ok that it is big. We just do not want multiple different things in the same PR or all PRs to be this big.

Copy link
Member

@Cliftonz Cliftonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zkhussain zkhussain changed the base branch from dev to main January 11, 2022 01:43
@zkhussain zkhussain changed the base branch from main to dev January 11, 2022 01:43
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

# Conflicts:
#	src/redux/selectors/entities.ts
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants