add playback success + update css purecss + reorder columns + update crystal version #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unixfox
changed the title
syeopite
approved these changes
Nov 4, 2023
| @@ -18,7 +18,7 @@ jobs: | |||
| - name: Install Crystal | |||
| uses: oprypin/install-crystal@v1 | |||
There was a problem hiding this comment.
Suggested change
| uses: oprypin/install-crystal@v1 | |
| uses: crystal-lang/install-crystal@v1.8.1 |
| @@ -160,6 +160,7 @@ SORT_PROCS = { | |||
| "api" => ->(name : String, instance : Instance) { instance[:api] == nil ? 2 : instance[:api] ? 0 : 1 }, | |||
| "users" => ->(name : String, instance : Instance) { -(instance[:stats]?.try &.["usage"]?.try &.["users"]["total"].as_i || 0) }, | |||
| "version" => ->(name : String, instance : Instance) { instance[:stats]?.try &.["software"]?.try &.["version"].as_s.try &.split("-", 2)[0].split(".").map { |a| -a.to_i } || [0, 0, 0] }, | |||
| "playback" => ->(name : String, instance : Instance) { -(instance[:stats]?.try &.["playback"]?.try &.["ratio"]?.try { |ratio| ratio.as_f } || 0.0) }, | |||
There was a problem hiding this comment.
What do you think about latching onto the previous (populated) playback success statistics so that we mostly won't get an empty playback stats data?
|
Waiting for a feedback for iv-org/invidious#4231 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the new statistic called "playback success" (related iv-org/invidious#4085) to the column so that the user can choose instances that have working local playback (and working DASH).
I did try to add meaningful tooltips. I'm bad at CSS, so I removed the arrow that points to what the tooltip is for.
Also, I did reorder the columns and placed from the left the most important ones because I think it's more user-friendly. Not sure why we are keeping "cors" while it could just be available only in the JSON API.
Finally, I upgraded purecss from v1.0.1 to v3.0.0 and also to crystal 1.10.1
Results :
Tooltips:
