Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] sig_helper: If more than 5 minutes passed since player js fetch it will never be fetched again #4840

Closed
MMaster opened this issue Aug 14, 2024 · 1 comment · Fixed by #4845
Closed

[Bug] sig_helper: If more than 5 minutes passed since player js fetch it will never be fetched again #4840

MMaster opened this issue Aug 14, 2024 · 1 comment · Fixed by #4845
Assignees
@SamantazFox
Labels
bug Something isn't working sig_helper

Comments

@MMaster
Copy link

MMaster commented Aug 14, 2024

Condition to check if player was fetched in last 5 minutes is reversed and it will early return if more than 5 minutes passed.

https://github.com/iv-org/invidious/blob/master/src/invidious/helpers/signatures.cr#L16
@MMaster MMaster added the bug Something isn't working label Aug 14, 2024
@unixfox unixfox changed the title [Bug] If more than 5 minutes passed since player js fetch it will never be fetched again [Bug] sig_helper: If more than 5 minutes passed since player js fetch it will never be fetched again Aug 14, 2024
@SamantazFox
Copy link
Member

Nice catch, thanks!

@SamantazFox SamantazFox mentioned this issue Aug 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SamantazFox SamantazFox

Labels
bug Something isn't working sig_helper
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SigHelper: Fix inverted time comparison in 'check_update' SamantazFox/invidious
3 participants
@unixfox @MMaster @SamantazFox