Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SigHelper: Fix inverted time comparison in 'check_update' #4845

Merged
merged 1 commit into from
Aug 24, 2024
Merged

SigHelper: Fix inverted time comparison in 'check_update' #4845

merged 1 commit into from
Aug 24, 2024

Conversation

SamantazFox
Copy link
Member

Closes #4840

@SamantazFox SamantazFox requested a review from a team as a code owner August 14, 2024 19:44
@SamantazFox SamantazFox requested review from syeopite and removed request for a team August 14, 2024 19:44
@SamantazFox SamantazFox added need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something ready and removed need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something labels Aug 24, 2024
@SamantazFox SamantazFox merged commit 15669ac into iv-org:master Aug 24, 2024
7 of 8 checks passed
@SamantazFox SamantazFox deleted the fix_time_comparison branch August 24, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syeopite syeopite syeopite approved these changes

Assignees
No one assigned
Labels
ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] sig_helper: If more than 5 minutes passed since player js fetch it will never be fetched again
2 participants
@SamantazFox @syeopite