Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth: Add username to token callback #3603

Merged
merged 1 commit into from
Feb 19, 2023
Merged

Auth: Add username to token callback #3603

merged 1 commit into from
Feb 19, 2023

Conversation

iBicha
Copy link
Contributor

@iBicha iBicha commented Jan 30, 2023

When getting a token to a 3rd party, we need to at least the username to display it to the user (so they can logout if this is not their profile)
This adds the username to the callback.

@iBicha iBicha requested a review from a team as a code owner January 30, 2023 15:50
@iBicha iBicha requested review from unixfox and removed request for a team January 30, 2023 15:50
@iBicha iBicha mentioned this pull request Jan 30, 2023
@iBicha
Copy link
Contributor Author

iBicha commented Feb 17, 2023

@unixfox thoughts?

Copy link
Member

@unixfox unixfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't break existing implementations, so why not adding it

@SamantazFox SamantazFox changed the title Add username to auth token callback Auth: Add username to token callback Feb 19, 2023
@SamantazFox SamantazFox merged commit cbbec00 into iv-org:master Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants