Added search button to search box #4098
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a search button, because some mobile or TV browsers like Amazon Silk do not submit the search query after entering a value into the search box.
syeopite
requested changes
Sep 14, 2023
| @@ -5,5 +5,6 @@ | |||
| name="q" placeholder="<%= translate(locale, "search") %>" | |||
| title="<%= translate(locale, "search") %>" | |||
| value="<%= env.get?("search").try {|x| HTML.escape(x.as(String)) } %>"> | |||
| <input type="submit" value="<%= translate(locale, "search") %>"> | |||
There was a problem hiding this comment.
Just a UI suggestion:
Before:
After:
Suggested change
| <input type="submit" value="<%= translate(locale, "search") %>"> | |
| <button class="search-button" id="right-overlap-search-button" type="submit"><i class="icon ion-md-search"></i></button> |
Styling: add it to default.css
.search-button {
border: none;
color: #3E4446;
background: transparent;
font-size: 1.1em;
}
.search-button:hover {
color: #090909;
}
#right-overlap-search-button {
float: right;
position: relative;
bottom: 1.8em;
}
There was a problem hiding this comment.
I like the suggestion but an aria-label would need to be added to that button to make it accessible for visually impaired users
... type="submit" aria-label="<%= translate(locale, "search") %>"><i ...
|
@viciousvex Can you please implement the changes proposed by the reviewers? |
|
This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked. |
SamantazFox
added
unfinished
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #529
Added a search button, because some mobile or TV browsers like Amazon Silk do not submit the search query after entering a value into the search box.