-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Channels: Add sort options to streams #4224
Conversation
Yes, merging the two in a single function is strongly preferred. |
I made the requested changes but couldn't test it yet because YouTube is blocked in my country, shouldn't be merged until then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good! I'm only asking for a few style/syntax changes ^^
Done, sorry for delay. Been busy with midterms. |
@src-tinkerer yeah, sure, no problem ^^ With my 60+ pending PRs to review, that'd be quite ironic for me to ask you to reply in a timely manner x) |
Will test this week |
Okay done testing and live stream sort works. |
This comment has been minimized.
This comment has been minimized.
Thanks for your contribution :) |
Uses the same method that is used for videos. We create continuation based on the sort option. One note though,
produce_channel_livestreams_continuation
andproduce_channel_videos_continuation
are almost identical, so is it better to simply make a singular function that produces the continuation based on the content?