Videos: Fix genre url being unusable #4717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syeopite
approved these changes
Jun 16, 2024
There was a problem hiding this comment.
I'm fine with this.
Though the []? probably isn't needed as genreUcid is always present anyways.
And regarding spec compliance, if it makes more sense for genreUcid to default to nil and it doesn't mess with the API then its a better idea to just modify the specs rather than forcing compliance through an empty string.
syeopite
added
the
need-testing
SamantazFox
added
in-testing
SamantazFox
changed the title
|
Thanks for your contribution ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4700