Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ameba: Disable rules #4792

Merged
merged 5 commits into from
Jul 27, 2024
Merged

Ameba: Disable rules #4792

merged 5 commits into from
Jul 27, 2024

Conversation

syeopite
Copy link
Member

Maybe Naming/BlockParameterName as well

@SamantazFox
Copy link
Member

Maybe Naming/BlockParameterName as well

I'm in favor of that one, yes.
there are a lots of places (like in src/invidious/videos/video_preferences.cr or in heavy JSON parsing sections) where it's just noise.

@syeopite syeopite changed the title Disable ameba rules Ameba: Disable rules Jul 17, 2024
SamantazFox
SamantazFox approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@SamantazFox SamantazFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@syeopite syeopite marked this pull request as ready for review July 27, 2024 02:30
@syeopite syeopite requested a review from a team as a code owner July 27, 2024 02:30
@syeopite syeopite requested review from unixfox and removed request for a team July 27, 2024 02:30
@syeopite
Copy link
Member Author

Merging as to reduce the amount of failures within the Ameba CI

@syeopite syeopite merged commit 90e94d4 into iv-org:master Jul 27, 2024
7 of 8 checks passed
@syeopite syeopite deleted the disable-ameba-rules branch July 27, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamantazFox SamantazFox SamantazFox approved these changes

@unixfox unixfox Awaiting requested review from unixfox unixfox is a code owner automatically assigned from iv-org/developers

Assignees
No one assigned
Labels
discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syeopite @SamantazFox