Fix CI: tests and coverage #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added unit tests for CI coverage
…ct like a mail client... version 2 (#4) * chore: satisfy all ruff checks in tests * feat: redo entire hw1 pr * fix: redo adapter test * fix: satisfy mypy * fix: let adapter set environment variable outside * fix(test): use subprocess instead to fix circleci * chore: move gmail-related tests to appropriate unit test location * chore: mkdocs * chore: lint, remove test conflict * feat: add dockerfile * chore: remove duplicate lint/coverage config
- Add comprehensive TrelloClient ABC with CRUD operations for boards, lists, cards - Define data models: TrelloBoard, TrelloList, TrelloCard, TrelloUser - Implement exception hierarchy for error handling - Add proper package structure with type hints
- Add TrelloClientImpl with full API operations - Implement OAuth 2.0 flow for Trello authentication - Add PostgreSQL database support for credential storage - Include comprehensive error handling and async support - Add service structure and basic testing framework
- Add comprehensive REST API with OAuth 2.0 endpoints - Implement all CRUD operations for boards, lists, and cards - Add proper error handling and HTTP status codes - Include health check endpoint for deployment - Add service documentation and basic tests
- Update all Trello components to use Python >=3.11 instead of >=3.12 - Add proper workspace dependency configuration - Update mypy and ruff target versions to match project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Related Issues
Change Type
Impacted Areas
mail_client_apigmail_client_implTesting
Commands executed
Results
Quality Checklist
Breaking Changes (skip if none)
Notes for Reviewers
Call out tricky areas, follow-ups, or validation details.