Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistency of Haskell code style - removing commented code/notes/todos #202

Closed
ivanperez-keera opened this issue Apr 7, 2022 · 0 comments
Closed

Consistency of Haskell code style - removing commented code/notes/todos #202

ivanperez-keera opened this issue Apr 7, 2022 · 0 comments
Assignees
@ivanperez-keera
Labels
enhancement maintenance
Milestone
Yampa 0.13.4

Comments

@ivanperez-keera
Copy link
Owner

A number of optional style suggestions were not implemented in #200 (see #200 (comment)).

The code is not a place to store todos, commented code and notes for pending changes. These should be documented externally using a mechanism that ensures that they are addressed at some point.
@ivanperez-keera ivanperez-keera self-assigned this Apr 7, 2022
ivanperez-keera added a commit that referenced this issue Apr 7, 2022
@ivanperez-keera
Remove commented code, comments to follow up on. Refs #202.
96fa244 
The code in Yampa contains annotations that should be addressed, todos,
commented code, etc.

This commit removes all those annotations, as they belong elsewhere in
the project (outside the code).
@ivanperez-keera ivanperez-keera changed the title Consistency of haskell code style (suggestions) - removing commented code/notes/todos Consistency of Haskell code style - removing commented code/notes/todos Apr 7, 2022
ivanperez-keera added a commit that referenced this issue Apr 7, 2022
@ivanperez-keera
Document changes in CHANGELOG. Refs #202.
62ce456
@ivanperez-keera ivanperez-keera mentioned this issue Apr 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanperez-keera ivanperez-keera

Labels
enhancement maintenance
Projects
None yet
Milestone
Yampa 0.13.4
Development

No branches or pull requests
1 participant
@ivanperez-keera