Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yampa: Simplify FRP.Yampa.Task.isEdge #287

Closed
ivanperez-keera opened this issue Feb 9, 2024 · 0 comments
Closed

yampa: Simplify FRP.Yampa.Task.isEdge #287

ivanperez-keera opened this issue Feb 9, 2024 · 0 comments
Assignees
@ivanperez-keera
Labels
enhancement
Milestone
0.14.7

Comments

@ivanperez-keera
Copy link
Owner

ivanperez-keera commented Feb 9, 2024 •
edited
Loading

The auxiliary function FRP.Yampa.Task.isEdge can be simplified by changing the order or cases:

Yampa/yampa/src/FRP/Yampa/Task.hs

Lines 97 to 100 in fc47e03

isEdge (Left _) (Left _) = Nothing
isEdge (Left _) (Right c) = Just c
isEdge (Right _) (Right _) = Nothing
isEdge (Right _) (Left _) = Nothing

@ivanperez-keera ivanperez-keera self-assigned this Feb 9, 2024
@ivanperez-keera ivanperez-keera added this to the 0.14.7 milestone Feb 9, 2024
ivanperez-keera added a commit that referenced this issue Feb 9, 2024
@ivanperez-keera
yampa: Simplify FRP.Yampa.Task.isEdge. Refs #287.
54f49a2 
Simplify the definition of FRP.Yampa.Task.isEdge by changing the order
of cases in the definition.
ivanperez-keera added a commit that referenced this issue Feb 9, 2024
@ivanperez-keera
yampa: Document changes in CHANGELOG. Refs #287.
e4c12c8
ivanperez-keera added a commit that referenced this issue Feb 9, 2024
@ivanperez-keera
yampa: Document changes in CHANGELOG. Refs #287.
f76f9d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanperez-keera ivanperez-keera

Labels
enhancement
Projects
None yet
Milestone
0.14.7
Development

No branches or pull requests
1 participant
@ivanperez-keera