Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dunai: Consistency of Haskell code style (part 2) #285

Closed
ivanperez-keera opened this issue Jun 3, 2022 · 0 comments
Closed

dunai: Consistency of Haskell code style (part 2) #285

ivanperez-keera opened this issue Jun 3, 2022 · 0 comments
Labels
enhancement
Milestone
Release 0.8.3

Comments

@ivanperez-keera
Copy link
Owner

ivanperez-keera commented Jun 3, 2022 •
edited
Loading

Starting from this comment, I have looked at this Haskell style guide.

  • Implement: 80-column limit.
  • Group imports (internal, external).
  • Explicit imports.
  • Spaces after commas.
@ivanperez-keera ivanperez-keera added this to the (+1) milestone Jun 3, 2022
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Wrap lines at 80 columns (KSG Haskell 1.3.0 - 4.3). Refs #285.
c86288e 
We set the code limit for Haskell files at 80 characters. A "character"
means any Unicode code point. Any line that would exceed this limit
should be line-wrapped.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Wrap lines at 80 columns (KSG Haskell 1.3.0 - 4.3). Refs #285.
348f515 
We set the code limit for Haskell files at 80 characters. A "character"
means any Unicode code point. Any line that would exceed this limit
should be line-wrapped.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Wrap lines at 80 columns (KSG Haskell 1.3.0 - 4.3). Refs #285.
090ab1b 
We set the code limit for Haskell files at 80 characters. A "character"
means any Unicode code point. Any line that would exceed this limit
should be line-wrapped.

We break move a definition in a where clause to a new line because it
goees over 80 columns. Technically, those could be two different style
rules being applied.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Wrap lines at 80 columns (KSG Haskell 1.3.0 - 4.3). Refs #285.
1866e54 
We set the code limit for Haskell files at 80 characters. A "character"
means any Unicode code point. Any line that would exceed this limit
should be line-wrapped.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Wrap lines at 80 columns (KSG Haskell 1.3.0 - 4.3). Refs #285.
08a1acc 
We set the code limit for Haskell files at 80 characters. A "character"
means any Unicode code point. Any line that would exceed this limit
should be line-wrapped.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Wrap lines at 80 columns (KSG Haskell 1.3.0 - 4.3). Refs #285.
ca42128 
We set the code limit for Haskell files at 80 characters. A "character"
means any Unicode code point. Any line that would exceed this limit
should be line-wrapped.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Wrap lines at 80 columns (KSG Haskell 1.3.0 - 4.3). Refs #285.
b5b5d71 
We set the code limit for Haskell files at 80 characters. A "character"
means any Unicode code point. Any line that would exceed this limit
should be line-wrapped.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Add space after comma (KSG Haskell 1.3.0 - 4.3.5). Refs #285.
257969f 
A single space should also appear after the comma (,) in lists and
tuples.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Add space after comma (KSG Haskell 1.3.0 - 4.3.5). Refs #285.
deca396 
A single space should also appear after the comma (,) in lists and
tuples.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Add space after comma (KSG Haskell 1.3.0 - 4.3.5). Refs #285.
c9b782f 
A single space should also appear after the comma (,) in lists and
tuples.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Add space after comma (KSG Haskell 1.3.0 - 4.3.5). Refs #285.
a0eb078 
A single space should also appear after the comma (,) in lists and
tuples.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Add space after comma (KSG Haskell 1.3.0 - 4.3.5). Refs #285.
b8b8b1a 
A single space should also appear after the comma (,) in lists and
tuples.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Group imports (KSG Haskell 1.3.0 - 3.5). Refs #285.
1bb659f 
Imports should be grouped between external imports, external imports
from the same project (but different libraries) and internal imports.
When groups are used, comments must be used to indicate the nature of
each group.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Group imports (KSG Haskell 1.3.0 - 3.5). Refs #285.
06bcba5 
Imports should be grouped between external imports, external imports
from the same project (but different libraries) and internal imports.
When groups are used, comments must be used to indicate the nature of
each group.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Group imports (KSG Haskell 1.3.0 - 3.5). Refs #285.
94cdbad 
Imports should be grouped between external imports, external imports
from the same project (but different libraries) and internal imports.
When groups are used, comments must be used to indicate the nature of
each group.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Group imports (KSG Haskell 1.3.0 - 3.5). Refs #285.
1cd7c6f 
Imports should be grouped between external imports, external imports
from the same project (but different libraries) and internal imports.
When groups are used, comments must be used to indicate the nature of
each group.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Group imports (KSG Haskell 1.3.0 - 3.5). Refs #285.
260632f 
Imports should be grouped between external imports, external imports
from the same project (but different libraries) and internal imports.
When groups are used, comments must be used to indicate the nature of
each group.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Group imports (KSG Haskell 1.3.0 - 3.5). Refs #285.
5f25a79 
Imports should be grouped between external imports, external imports
from the same project (but different libraries) and internal imports.
When groups are used, comments must be used to indicate the nature of
each group.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Group imports (KSG Haskell 1.3.0 - 3.5). Refs #285.
070fb62 
Imports should be grouped between external imports, external imports
from the same project (but different libraries) and internal imports.
When groups are used, comments must be used to indicate the nature of
each group.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Group imports (KSG Haskell 1.3.0 - 3.5). Refs #285.
877de6d 
Imports should be grouped between external imports, external imports
from the same project (but different libraries) and internal imports.
When groups are used, comments must be used to indicate the nature of
each group.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Group imports (KSG Haskell 1.3.0 - 3.5). Refs #285.
ff8db33 
Imports should be grouped between external imports, external imports
from the same project (but different libraries) and internal imports.
When groups are used, comments must be used to indicate the nature of
each group.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Group imports (KSG Haskell 1.3.0 - 3.5). Refs #285.
dc966ef 
Imports should be grouped between external imports, external imports
from the same project (but different libraries) and internal imports.
When groups are used, comments must be used to indicate the nature of
each group.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Group imports (KSG Haskell 1.3.0 - 3.5). Refs #285.
50df3ea 
Imports should be grouped between external imports, external imports
from the same project (but different libraries) and internal imports.
When groups are used, comments must be used to indicate the nature of
each group.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Group imports (KSG Haskell 1.3.0 - 3.5). Refs #285.
950b4b3 
Imports should be grouped between external imports, external imports
from the same project (but different libraries) and internal imports.
When groups are used, comments must be used to indicate the nature of
each group.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Group imports (KSG Haskell 1.3.0 - 3.5). Refs #285.
a7ce66a 
Imports should be grouped between external imports, external imports
from the same project (but different libraries) and internal imports.
When groups are used, comments must be used to indicate the nature of
each group.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Group imports (KSG Haskell 1.3.0 - 3.5). Refs #285.
b91e567 
Imports should be grouped between external imports, external imports
from the same project (but different libraries) and internal imports.
When groups are used, comments must be used to indicate the nature of
each group.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Group imports (KSG Haskell 1.3.0 - 3.5). Refs #285.
1388419 
Imports should be grouped between external imports, external imports
from the same project (but different libraries) and internal imports.
When groups are used, comments must be used to indicate the nature of
each group.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Group imports (KSG Haskell 1.3.0 - 3.5). Refs #285.
6511359 
Imports should be grouped between external imports, external imports
from the same project (but different libraries) and internal imports.
When groups are used, comments must be used to indicate the nature of
each group.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Make imports explicit (KSG Haskell 1.3.0 - 3.5). Refs #285.
70cb80d 
Imports should be explicit (aka. no wildcard imports).
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Make imports explicit (KSG Haskell 1.3.0 - 3.5). Refs #285.
22d085b 
Imports should be explicit (aka. no wildcard imports).

Remove import that is empty when made explicit.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Make imports explicit (KSG Haskell 1.3.0 - 3.5). Refs #285.
5272264 
Imports should be explicit (aka. no wildcard imports).
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Make imports explicit (KSG Haskell 1.3.0 - 3.5). Refs #285.
01ae4ee 
Imports should be explicit (aka. no wildcard imports).
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Make imports explicit (KSG Haskell 1.3.0 - 3.5). Refs #285.
fbc877c 
Imports should be explicit (aka. no wildcard imports).

Remove import that is empty when made explicit.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
Document changes in dunai:CHANGELOG. Refs #285.
ff6d872
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Make imports explicit (KSG Haskell 1.3.0 - 3.5). Refs #285.
20991e6 
Imports should be explicit (aka. no wildcard imports).

Remove import that is empty when made explicit.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
Document changes in dunai:CHANGELOG. Refs #285.
1fedca5
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Make imports explicit (KSG Haskell 1.3.0 - 3.5). Refs #285.
4ddb509 
Imports should be explicit (aka. no wildcard imports).
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Make imports explicit (KSG Haskell 1.3.0 - 3.5). Refs #285.
7dc7349 
Imports should be explicit (aka. no wildcard imports).
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Make imports explicit (KSG Haskell 1.3.0 - 3.5). Refs #285.
9c7760e 
Imports should be explicit (aka. no wildcard imports).
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Make imports explicit (KSG Haskell 1.3.0 - 3.5). Refs #285.
420a37e 
Imports should be explicit (aka. no wildcard imports).
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Make imports explicit (KSG Haskell 1.3.0 - 3.5). Refs #285.
8383f39 
Imports should be explicit (aka. no wildcard imports).
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Make imports explicit (KSG Haskell 1.3.0 - 3.5). Refs #285.
a6891c5 
Imports should be explicit (aka. no wildcard imports).
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Make imports explicit (KSG Haskell 1.3.0 - 3.5). Refs #285.
3a7e39b 
Imports should be explicit (aka. no wildcard imports).
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Make imports explicit (KSG Haskell 1.3.0 - 3.5). Refs #285.
6628ac1 
Imports should be explicit (aka. no wildcard imports).
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Make imports explicit (KSG Haskell 1.3.0 - 3.5). Refs #285.
e72c767 
Imports should be explicit (aka. no wildcard imports).
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Make imports explicit (KSG Haskell 1.3.0 - 3.5). Refs #285.
e30c847 
Imports should be explicit (aka. no wildcard imports).
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Make imports explicit (KSG Haskell 1.3.0 - 3.5). Refs #285.
add5be0 
Imports should be explicit (aka. no wildcard imports).
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Make imports explicit (KSG Haskell 1.3.0 - 3.5). Refs #285.
2d2960b 
Imports should be explicit (aka. no wildcard imports).
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Make imports explicit (KSG Haskell 1.3.0 - 3.5). Refs #285.
0964407 
Imports should be explicit (aka. no wildcard imports).
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Make imports explicit (KSG Haskell 1.3.0 - 3.5). Refs #285.
d58dee6 
Imports should be explicit (aka. no wildcard imports).
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Make imports explicit (KSG Haskell 1.3.0 - 3.5). Refs #285.
f9c2c3c 
Imports should be explicit (aka. no wildcard imports).

Remove import that is empty when made explicit.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Make imports explicit (KSG Haskell 1.3.0 - 3.5). Refs #285.
6d221fd 
Imports should be explicit (aka. no wildcard imports).
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Make imports explicit (KSG Haskell 1.3.0 - 3.5). Refs #285.
6f7589d 
Imports should be explicit (aka. no wildcard imports).
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
dunai: Make imports explicit (KSG Haskell 1.3.0 - 3.5). Refs #285.
02db25e 
Imports should be explicit (aka. no wildcard imports).

Remove import that is empty when made explicit.
ivanperez-keera added a commit that referenced this issue Jun 3, 2022
@ivanperez-keera
Document changes in dunai:CHANGELOG. Refs #285.
a7e88ea
@ivanperez-keera ivanperez-keera mentioned this issue Jun 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Release 0.8.3
Development

No branches or pull requests
1 participant
@ivanperez-keera