Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bearriver: Offer all definitions from FRP.Yampa.Conditional #382

Closed
ivanperez-keera opened this issue Oct 21, 2023 · 0 comments
Closed

bearriver: Offer all definitions from FRP.Yampa.Conditional #382

ivanperez-keera opened this issue Oct 21, 2023 · 0 comments
Assignees
@ivanperez-keera
Labels
enhancement
Milestone
Dunai 0.12.0

Comments

@ivanperez-keera
Copy link
Owner

The module FRP.Yampa.Conditional is being offered by Yampa, but not bearriver.

This makes the interface offered by bearriver not compliant with Yampa, therefore not delivering on the promise of being API-compatible.

This is a subissue of #40. Because #40 is a big issue, it's good to split it in several smaller ones.
@ivanperez-keera ivanperez-keera added this to the Dunai 0.11.3 milestone Oct 21, 2023
@ivanperez-keera ivanperez-keera self-assigned this Oct 21, 2023
ivanperez-keera added a commit that referenced this issue Oct 21, 2023
@ivanperez-keera
bearriver: Move definitions into FRP.BearRiver.Switches. Refs #382.
5d21612 
Several definitions are currently being defined in FRP.BearRiver that,
in Yampa, are instead defined in an internal module FRP.Yampa.Switches.
To make it easier to port code over from Yampa to bearriver, we decide
to move those definitions into a matching module FRP.BearRiver.Switches
on the bearriver side.

The module is currently incomplete. Not all definitions from
FRP.Yampa.Switches exist in FRP.BearRiver. This commit moves only those
definitions that currently are being exported by FRP.BearRiver.
ivanperez-keera added a commit that referenced this issue Oct 21, 2023
@ivanperez-keera
bearriver: Move definitions into FRP.BearRiver.EventS. Refs #382.
c2d3d1a 
Several definitions are currently being defined in FRP.BearRiver that,
in Yampa, are instead defined in an internal module FRP.Yampa.EventS. To
make it easier to port code over from Yampa to bearriver, we decide to
move those definitions into a matching module FRP.BearRiver.EventS on
the bearriver side.

The module is currently incomplete. Not all definitions from
FRP.Yampa.EventS exist in FRP.BearRiver. This commit moves only those
definitions that currently are being exported by FRP.BearRiver.
ivanperez-keera added a commit that referenced this issue Oct 21, 2023
@ivanperez-keera
bearriver: Port module FRP.Yampa.Conditional to bearriver. Refs #382.
1d035f0 
The module FRP.Yampa.Conditional is being offered by Yampa, but not
bearriver. This makes the interface offered by bearriver not compliant
with Yampa, therefore not delivering on the promise of being
API-compatible.

This commit adds the module FRP.Yampa.Conditional into bearriver, as
FRP.BearRiver.Conditional.
ivanperez-keera added a commit that referenced this issue Oct 21, 2023
@ivanperez-keera
bearriver: Document changes in CHANGELOG. Refs #382.
23e4eda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanperez-keera ivanperez-keera

Labels
enhancement
Projects
None yet
Milestone
Dunai 0.12.0
Development

No branches or pull requests
1 participant
@ivanperez-keera