bearriver: Offer all definitions from FRP.Yampa.EventS
#400
Comments
ivanperez-keera
added a commit
that referenced
this issue
Feb 22, 2024
Several definitions are currently being defined in FRP.BearRiver that, in Yampa, are instead defined in an internal module FRP.Yampa.Hybrid. To make it easier to port code over from Yampa to bearriver, we decide to move those definitions into a matching module FRP.BearRiver.Hybrid on the bearriver side. The module is currently incomplete. Not all definitions from FRP.Yampa.Hybrid exist in FRP.BearRiver. This commit moves only those definitions that currently are being exported by FRP.BearRiver, which EventS depends on.
ivanperez-keera
added a commit
that referenced
this issue
Feb 22, 2024
The module FRP.BearRiver.EventS does not contain all definitions offered by its Yampa counterpart. This makes the interface offered by bearriver not compliant with Yampa, therefore not delivering on the promise of being API-compatible. This commit adds missing definitions to the module FRP.BearRiver.EventS. Several definitions are moved inside the module to ensure it follows the same order as FRP.Yampa.EventS, which makes ensuring consistency across both packages easier.
ivanperez-keera
added a commit
that referenced
this issue
Feb 22, 2024
ivanperez-keera
added a commit
that referenced
this issue
Feb 22, 2024
Several definitions are currently being defined in FRP.BearRiver that, in Yampa, are instead defined in an internal module FRP.Yampa.Hybrid. To make it easier to port code over from Yampa to bearriver, we decide to move those definitions into a matching module FRP.BearRiver.Hybrid on the bearriver side. The module is currently incomplete. Not all definitions from FRP.Yampa.Hybrid exist in FRP.BearRiver. This commit moves only those definitions that currently are being exported by FRP.BearRiver, which EventS will depend on.
ivanperez-keera
added a commit
that referenced
this issue
Feb 22, 2024
The module FRP.BearRiver.EventS does not contain all definitions offered by its Yampa counterpart. This makes the interface offered by bearriver not compliant with Yampa, therefore not delivering on the promise of being API-compatible. This commit adds missing definitions to the module FRP.BearRiver.EventS. Several definitions are moved inside the module to ensure it follows the same order as FRP.Yampa.EventS, which makes ensuring consistency across both packages easier.
ivanperez-keera
added a commit
that referenced
this issue
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The module
FRP.Yampa.EventSis being offered by Yampa, but notbearriver.This makes the interface offered by
bearrivernot compliant withYampa, therefore not delivering on the promise of being API-compatible.This is a subissue of #40. Because #40 is a big issue, it's good to split it in several smaller ones.
The text was updated successfully, but these errors were encountered: