Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bearriver: Offer all definitions from FRP.Yampa.Integration #422

Closed
ivanperez-keera opened this issue Jun 22, 2024 · 0 comments
Closed

bearriver: Offer all definitions from FRP.Yampa.Integration #422

ivanperez-keera opened this issue Jun 22, 2024 · 0 comments
Assignees
Milestone

Comments

@ivanperez-keera
Copy link
Owner

The module FRP.Yampa.Integration is being offered by Yampa, but not bearriver.

This makes the interface offered by bearriver not compliant with Yampa, therefore not delivering on the promise of being API-compatible.

This is a subissue of #40. Because #40 is a big issue, it's good to split it in several smaller ones.

@ivanperez-keera ivanperez-keera added this to the Dunai 0.14.0 milestone Jun 22, 2024
@ivanperez-keera ivanperez-keera self-assigned this Jun 22, 2024
ivanperez-keera added a commit that referenced this issue Jun 22, 2024
The module FRP.BearRiver.Integration does not contain all definitions offered
by its Yampa counterpart. This makes the interface offered by bearriver
not compliant with Yampa, therefore not delivering on the promise of
being API-compatible.

This commit adds missing definitions to the module FRP.BearRiver.Integration.
Comments are changed inside the module to match FRP.Yampa.Integration.

A definition is hidden in an import in FRP.BearRiver, since it now
clashes with one being offered by this module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant