0.3.1 breaks on Windows

[joelfried]

Commit 07f7db7 changed index.js to use path.join() in a way that breaks this package for Windows users.

A fix is documented in this thread - it looks like just fixing line 99 may be sufficient.

[ivanvanderbyl]

@joelfried we'd happily accept a pull request for this. At present I don't have a windows environment to test a fix on.

[joelfried]

@ivanvanderbyl I've created a pull request that resolves this issue.

[raytiley]

I can confirm I'm seeing this on our appveyor CI

The Broccoli Plugin: [Funnel] failed with:
Error: ENOENT: no such file or directory, symlink 'C:\projects\reflect-ui\tmp\funnel-input_base_path-BiUHkkq6.tmp\ember-d3\register-version.js' -> 'C:\projects\reflect-ui\tmp\funnel-output_path-4BGqy7Jn.tmp\ember-d3\register-d3-version.js'
    at Error (native)
    at Object.fs.symlinkSync (fs.js:1054:18)
    at symlinkWindows (C:\projects\reflect-ui\node_modules\symlink-or-copy\index.js:120:16)
    at Function.symlinkOrCopySync [as sync] (C:\projects\reflect-ui\node_modules\symlink-or-copy\index.js:63:5)
    at Funnel._copy (C:\projects\reflect-ui\node_modules\broccoli-funnel\index.js:467:19)
    at Funnel.processFile (C:\projects\reflect-ui\node_modules\broccoli-funnel\index.js:450:8)
    at Funnel.applyPatch [as _applyPatch] (C:\projects\reflect-ui\node_modules\broccoli-funnel\index.js:367:12)
    at Funnel.<anonymous> (C:\projects\reflect-ui\node_modules\broccoli-funnel\index.js:321:10)
    at Array.forEach (native)
    at Funnel.processFilters (C:\projects\reflect-ui\node_modules\broccoli-funnel\index.js:320:11)
The broccoli plugin was instantiated at: 
    at Funnel.Plugin (C:\projects\reflect-ui\node_modules\broccoli-plugin\index.js:7:31)
    at new Funnel (C:\projects\reflect-ui\node_modules\broccoli-funnel\index.js:58:10)
    at rename (C:\projects\reflect-ui\node_modules\broccoli-stew\lib\rename.js:39:10)
    at Class.treeForVendor (C:\projects\reflect-ui\node_modules\ember-d3\index.js:98:18)
    at Class._treeFor (C:\projects\reflect-ui\node_modules\ember-cli\lib\models\addon.js:362:33)
    at Class.treeFor (C:\projects\reflect-ui\node_modules\ember-cli\lib\models\addon.js:330:21)
    at C:\projects\reflect-ui\node_modules\ember-cli\lib\models\addon.js:245:34
    at Array.map (native)
    at Class.eachAddonInvoke (C:\projects\reflect-ui\node_modules\ember-cli\lib\models\addon.js:243:24)
    at Class.treeFor (C:\projects\reflect-ui\node_modules\ember-cli\lib\models\addon.js:329:22)

[rwjblue]

Seems like #33 fixed the issue for us, but we still need a release.

@ivanvanderbyl - Any blockers on a release?

[ivanvanderbyl]

Nope, will cut one shortly when I get to a proper internet. Currently on Naxos, in 🇬🇷

On Tue, 16 May 2017 at 18:16, Robert Jackson ***@***.***> wrote: Seems like #33 <#33> fixed the issue for us, but we still need a release. @ivanvanderbyl <https://github.com/ivanvanderbyl> - Any blockers on a release? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#29 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABe1lCCo41H7o7Eqf1ejbfqOFPC0_Foks5r6b2tgaJpZM4MA8b4> .

-- Ivan Vanderbyl

[ivanvanderbyl]

@rwjblue released 0.3.3