Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setCurrentPosition using getCurrentPosition does not work #178

Closed
ivmartel opened this issue Oct 7, 2015 · 0 comments
Closed

setCurrentPosition using getCurrentPosition does not work #178

ivmartel opened this issue Oct 7, 2015 · 0 comments
Labels
bug Something isn't working
Milestone
0.12.0

Comments

@ivmartel
Copy link
Owner

ivmartel commented Oct 7, 2015

This example does not work:

 var p = app.getViewController().getCurrentPosition();
 p.k += 1;
 app.getViewController().setCurrentPosition(p);

The 'getCurrentPosition' must return a clone of the position to avoid manipulating the same object.
@ivmartel ivmartel added the bug Something isn't working label Oct 7, 2015
@ivmartel ivmartel added this to the 0.12.0 milestone Oct 7, 2015
ivmartel added a commit that referenced this issue Oct 7, 2015
@ivmartel
Revert "Return a clone of the position in getCurrentPosition. Fixes #178
b92b32b 
."

This reverts commit 7c446b7.
ivmartel added a commit that referenced this issue Oct 7, 2015
@ivmartel
Revert "Revert "Return a clone of the position in getCurrentPosition. F…
e1bb00c 
…ixes #178.""

This reverts commit b92b32b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.12.0
Development

No branches or pull requests
1 participant
@ivmartel